Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade track to PHP 8.1 - 8.3 and PHPUnit 10.5 #704

Merged
merged 7 commits into from
May 5, 2024
Merged

Upgrade track to PHP 8.1 - 8.3 and PHPUnit 10.5 #704

merged 7 commits into from
May 5, 2024

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented May 4, 2024

After putting all pre-requisites into place (see #652), this PR upgrades the track finally to the new versions.

  • Adds macOS14 to the CI (this is now the latest GitHub CI image)
  • Change versions in all documentation files
  • Raise versions for contribution, too

@mk-mxp mk-mxp added x:action/improve Improve existing functionality/content x:knowledge/intermediate Quite a bit of Exercism knowledge required x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/docs Work on Documentation x:size/medium Medium amount of work x:rep/medium Medium amount of reputation labels May 4, 2024
@mk-mxp mk-mxp requested a review from homersimpsons May 4, 2024 13:54
@mk-mxp mk-mxp self-assigned this May 4, 2024
@mk-mxp mk-mxp mentioned this pull request May 4, 2024
Open
19 tasks
homersimpsons
homersimpsons approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some minor comments here and there. Feel free to discuss them, I still approve the changes as-is.

docs/INSTALLATION.md Outdated Show resolved Hide resolved
docs/INSTALLATION.md Outdated Show resolved Hide resolved
exercises/shared/.docs/tests.md Outdated Show resolved Hide resolved
docs/INSTALLATION.md Show resolved Hide resolved
@mk-mxp mk-mxp merged commit 215022a into exercism:main May 5, 2024
12 checks passed
@mk-mxp mk-mxp deleted the upgrade-track-to-php83-phpunit10 branch May 5, 2024 07:37
tomasnorre pushed a commit to tomasnorre/exercism-php that referenced this pull request May 7, 2024
@mk-mxp @homersimpsons @tomasnorre
Upgrade track to PHP 8.1 - 8.3 and PHPUnit 10.5 (exercism#704)
09376cf 
Co-authored-by: homersimpsons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homersimpsons homersimpsons homersimpsons approved these changes

Assignees

@mk-mxp mk-mxp

Labels
x:action/improve Improve existing functionality/content x:knowledge/intermediate Quite a bit of Exercism knowledge required x:rep/medium Medium amount of reputation x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/docs Work on Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mk-mxp @homersimpsons